Simon Schölly

Hi, thanks for your contribution - It's been a few years since I last looked at Tarjans algorithm, so I will first have to figure out again how it works...

I stopped reviewing this PR, as you where pushing quite a lot of commits, so I wanted to wait until you get that done. I will try to continue the...

I would prefer if the adjacency matrix would not be the same as `weights` for all graphs - sometimes one is only interested in structural information so in that case...

I think this might be, because `diameter` works for the general case where an additional distance matrix is used. Internally it then uses `dijkstra_shortest_paths` instead of `gdistances`. Maybe we should...

I am not sure if Floyd-Warshall is much more performant unless one finds a way to avoid allocating the temporary `|V| x |V|` distance matrix. Best would probably to just...

Ok, I just realized that this was done on purpose in the past: https://github.com/JuliaGraphs/LightGraphs.jl/pull/603, but I would still say, that we should either forbid this function on undirected graphs or...

I think one definition of a cyclic undirected graph is a graph that has an edge that is *not* a bridge. I.e. a cycle in an undirected graph can not...

I think this has already been changed on the master branch so that this function works with any kind of `AbstractGraph`. Although it seems, that this function does not consider...

I think the problem is, that if you have ```julia set_prop!(G, 1, 2, :name, "a") set_prop!(G, 2, 1, :name, "b") ``` what should then the expected value for `get_prop(MetaGraph(G), 1,...

I think such a feature would make sense. But such a feature should only squash the topological information (i.e the wrapped graph) and not any metadata. Dictionaries with meta data...