Simon Schölly

Results 188 comments of Simon Schölly

I wonder how much NetworkLayout.jl is still maintained. Apparently it is still a dependency of GraphRecipes.jl, so it must still work but the current situation is: - the latest commit...

Hey Aurora, thanks for your PR. While it might be a very good idea, to return the same types from both algorithms, changing that now would break existing code, so...

> The checks are failing because of other parts of the code, not what is included in this PR. I'm still kinda new to this - what is the procedure...

> Ah, I see. I fixed the issue. Tests still show one error but it seems to be in a completely different module Indeed - apparently the tests are failing...

@kylebeggs If you rebase/merge the lastest master in your branch, the tests should pass now.

We could implement the `dropzeros!` method for `SimpleWeightedGraphs`, so we could remove all zero weight edges after a bunch of edge removals.

Hi, I did not have time yet to look to much into this PR, but it is highly appreciated. Will try to do that this week. The tests are a...

So I would suggest you add tests to `interface/modifiers.jl` - the tests for `rem_edge!` are already there. Eventually I will clean this up and just move these tests then somewhere...

I haven't looked into why this bug happens yet, but I doubt that ` triu` is the optional solution, as it allocates a new sparse matrix. Possible solutions for this...

Is there really a good use case for letting the user choose their own priority queue? Maybe we should just pick the fasted one for them. Also, currently the priority...