Simone Primarosa

Results 76 comments of Simone Primarosa

@w8r Thanks! I've already solved most of the problems anyway. I saw that that package has also the api to solve this https://github.com/w8r/avl/issues/21.

Changing: ``` "ignores": [ "bin" ] ``` to: ``` "ignores": [ "bin/**" ] ``` solved the problem. It makes sense to you to add a little note about the needs...

Ok now i understand. I believe that if you can find a way to make them run both would be a great thing ;)

Sorry this went off my radar. Do you still need that feature? For "Touching" you mean that they overlap?

It's really straightforward actually. We just need to change [this line](https://github.com/simonepri/geojson-geometries-lookup/blob/master/index.js#L129) and use [this package](https://www.npmjs.com/package/@turf/boolean-overlap)

Ok it was just an error in the draft: The test vectors inside the RFC are correct: https://tools.ietf.org/html/rfc7914#section-12

@barrysteyn maybe we can update the link in the readme?

Hi tabara@ thank you for the PR. I think the change should look like more like this (i.e. we need to introduce a `methodToRequireFn` function): https://github.com/simonepri/pidtree/commit/d3fb048078b4bacf96cd831226fb6c80fc341cc1

@timelf123 I think that this is an important feature. Since official plugins uses a strict name guidelines, I think is easy add an optional parameter the register method in order...

No problem! Thank you for you help! :octocat: I'll try to add more documentation on how to contribute soon, but if you need something just ask it here!