Simone Primarosa

Results 76 comments of Simone Primarosa

Sure, no hurry! The comment was meant as a reminder for the future.

What I would do is the following: First, You put your code inside a function called `_tokens_log_prob_for_sentence`. Then inside the `_tokens_log_prob_for_batch` you simply do a for loop that calls a...

Yes that's true, but it also makes the logic much much more easier to maintain. I would rather implement a simple version first test it, and then if it's worth...

@dldk-gael Sorry I don't have time at the moment to review the code. I should be able to come back to you in about a week. Ping me in case...

> Hah I just saw that https://github.com/Unitech/pm2/pull/3554/files basically IS such a PR Yes kind of. Actually my belief is that `taskkill` should be faster for windows.

I'll work on this as soon as possible, right now I'm a bit busy.