pidusage icon indicating copy to clipboard operation
pidusage copied to clipboard

Published 20 hours ago • verified publisher icon soyuka

Added compatibility to bundlers (closes #144 #152 #153)

Open tabarra opened this issue 3 years ago • 2 comments

Q A
Branch? main
Bug fix? yes
New feature? yes
Deprecations? no
Tickets Fix #144 #152 #153
License MIT
Doc PR not required

tabarra avatar Sep 15 '22 20:09 tabarra

Hi tabara@ thank you for the PR.

I think the change should look like more like this (i.e. we need to introduce a methodToRequireFn function): https://github.com/simonepri/pidtree/commit/d3fb048078b4bacf96cd831226fb6c80fc341cc1

simonepri avatar Sep 21 '22 14:09 simonepri

@simonepri Maybe, but that's fine because node caches modules so it's only actually included once.
I had to rush it just to be able to ship an update in my project, but might revisit it in the future.

tabarra avatar Sep 22 '22 01:09 tabarra

thanks kept your commits in #163 and added the change with as we'll need probably need it in https://github.com/soyuka/pidusage/pull/143

soyuka avatar Oct 25 '22 14:10 soyuka