Simone Primarosa

Results 76 comments of Simone Primarosa

If you are still interested these are the things to edit: Create a `pip` folder with the same structure of the `npm` one here: https://github.com/simonepri/geo-maps/tree/master/tpls Add `pip` in the following...

Hi @kevinries, I was planning to do it. I was just waiting for a clean way to do it using [mapshaper](https://github.com/mbloch/mapshaper). You can follow the [issue here](https://github.com/mbloch/mapshaper/issues/238#issue-277417978). Anyway I'll try...

I'll take a look asap! Thank you!

Can you search from where we can extract those data? An API endpoint or anything that can speed up the process would be welcomed. Thank You for the time you...

Which resolution are you using? This is the ` earth-coastlines-1m` map. And it's perfectly shaped. [![image](https://user-images.githubusercontent.com/3505087/35118393-e72943a2-fc91-11e7-86ff-2b1c46ec12f7.png)](http://mapshaper.org/?files=https://unpkg.com/@geo-maps/countries-coastline-1m/map.geo.json)

Yeah sadly is not. It mostly depends on the quality of the original map. Can you have a look on Open Street Map directly?

> For now, I pass all the mask sentences in one single batch to BERT so it may raise some memory problem for very long sentences. Can you please add...

I woud like to get #4 merged before reviewing this. Since we are chaning the API we have to update this PR later anyway.

Things todo here before we can merge this: - [ ] Refactor the code to match the new API - [ ] Update the tests to match the ones implemented...