Simon Baslé

Results 160 comments of Simon Baslé

@floriandreher do you actually need the `MyExchangeAdapter` class at all? I just tried with the default status handler and it seemed to work.

yeah I see what you mean, this is indeed not ideal because if the 404 response contains a body, having the empty `defaultStatusHandler` doesn't help as we'll ultimately attempt to...

there is no easy way forward that I could see after having fixed the case where it would grow indefinitely. so with the current implementation I thought that the compromise...

If a `TaskScheduler` is set, on the Spring side of things the heartbeat configuration becomes `10 000, 10 000` by default, indicating to the client that the server is capable...

actually if you go back to returning something and eliminate the subscriber, having a `Flowable` as the return type would work: libs like Reactor are capable of consuming any `Publisher`...

This is by no means a complete implementation but gives you an idea of how the API and internal class structure would look like. Note there's no particular request handling,...

Yeah, in terms of switching to RxJava, that would just be a matter of using `Flowable.fromPublisher(journalPublisher)`. Same for Reactor with `Flux.from(journalPublisher)`. In terms of backpressure and request handling, what I...

The requests add up and the publisher is now expected to send a _total_ of 7 values. Of course, if the journal only contains eg. 6, the publisher will `onComplete`...

another potential problem that I just thought about: the `ReplayRate.ACTUAL_TIME` would lead to the thread in which reactive signals are emitted to be blocked during `pause`. This is bad, as...