Simon Baslé

Results 160 comments of Simon Baslé

I'll need to rebase against current main (which depends on context-propagation M5)

As stated above, while we initially thought we'd take the Spring 6 release as an opportunity to bump our Java baseline as well, this was rolled back. Reactor isn't Spring,...

Yes, if we consider only `breakBuildOn*` type of options options there seems to be full coverage. The trouble is with the `isOutput*Modifications` options. These don't exactly mirror the 3 break-the-build...

that would mean doing the same for `reactor-test`. and suddenly, depending on `reactor-kotlin-extensions` eg just for the `toMono` core parts enforces a dependency on `reactor-addons` and `reactor-test`... the situation is...

linked to #22013 and superseded by gh-30396

Note that this is also the case for `ResponseBodyAssert#isEqualTo(String)` but this is a bit different as the method is a shortcut for `.asString().isEqualTo(String)`.

We should consider if the issue stems from the naming of `isEqualTo(String)`. This method's intention is to parse the provided `String` and compare it to the `actual MediaType`. As such...

Note: the first commit was closer to the arrangement found in Boot, but there was too much logic in the `annotation` package for my taste, and it was exposing `Unit`...

third iteration (missing a bit of documentation) is reintroducing `DurationFormat.Unit`, bearing part of the logic in dealing with suffixes and giving a better sense of exactly which units are actually...

I went that route for consistency with Framework current package arrangement, with some extra effort in avoiding too much logic in the annotation. `Unit`-related methods felt simple enough that they...