Simon Baslé

Results 160 comments of Simon Baslé

I've thought a bit about the implication of "making it configurable", and I think it is probably going to be too much work because it implies creating a new `Flux`...

yeah I don't think we can make that change, it would break the behavior of the operator (same as in that akka-streams issue)... merge + comparison + infinite stream is...

@chemicL what do you think of this piece of code to shutdown multiple executors at once, try to await as close to the grace period as possible while still only...

great job @chemicL ! finally approved and ready to merge 😄 now the only remaining step is to try to summarize the design of the change for the commit message...

I'm not sure there is a strong rationale behind it, but the core implementations have historically used `shutdownNow`. do you have a particular example where that hard shutdown is actually...

one alternative to the above would be to throw `UnsupportedOperationException` in the `disposeGracefully()` `default` implementation. this begs the question of which is more important. is it: 1. if the **graceful**...

@ZejiaJiang I agree that the two separate methods would provide choice. I'm just wondering what's best to happen if you do call `disposeGracefully` with an old `Scheduler` that didn't specifically...

Initially done in #2235 but I somehow closed it when I started `ContextView` change in a separate PR.

I still need to actually expose the configuration of `onErrorContinue`, which would be a prime beneficiary of this approach

@Sage-Pierce since I see that you've reworked your code, and since we've made other changes to groupBy in the past year, can this issue be closed?