Simon Baslé

Results 160 comments of Simon Baslé

Is that a typical arrangement @garyrussell @artembilan ? If the `kafka-client` (`KafkaConsumer`) doesn't install such a hook and puts the responsibility on the user, doesn't it make sense that the...

> > Also, KafkaSender has a close() but it doesn't extend the Closeable or AutoCloseable. It would be better if it extends the AutoCloseable so that it can be used...

(exposing a `close()` method where it is missing makes perfect sense though)

in that particular case, it potentially wouldn't even get a chance to deal with the `recordsPublisher` at all. I'm not sure of the exact behavior but I would expect the...

only actual occurrence I could find was at https://github.com/reactor/BlockHound/blob/e566a5327eb65afcd9a50ba282ee7ef6a678acc7/example/build.gradle#L29 is this what you're talking about? I'll also change the `testCompile` occurrences in documentation

Spotless should replace hyeronimus license plugin in projects that used the later. If `isCiServer` isn't available, it can be defined in a simplified form in `ext { ... }` as:...

Thanks for pointing that out @violetagg! And that's actually an argument in favor of doing per-project workflow, since reactor-netty has specifics (the build matrix with various OS and native notion)

Side note found while reproducing: for the agent to attach, here is the `module-info.java` that I ended up with: ```java module blockhoundNpe.main { requires jdk.attach; //required for bytebuddy to attach...

I'll need @bsideup's expertise here. It looks like with modules there is either an issue with `BlockHoundRuntime` being loaded outside the bootstrap classloader, or some initialization change that leads to...

The first of regexp will turn: ``` -....-..-...startOfText ``` into ``` ---..-...startOfText ``` (ie blocks of 4 spaces at the beginning of the line are turned into spaces, and right-padding...