Simon Mo comments

Results 313 comments of


                                            Simon Mo

TEST: Flaky test: TimeoutError from Ray not starting up on Windows

The error isn't giving us enough information. Can you try to print the system log in case of such failure: `tail /tmp/ray/session_latest/logs/*`

[Serve] [Doc] Update intro page

Thanks @dmatrix and @architkulkarni, comments addressed. @edoakes ready for your look.

[Serve] [Doc] Update intro page

Addressed!

[Core] [Hotfix] Change "task failed with unretryable exception" log statement to debug-level.

lint failed ``` python/ray/_raylet.pyx:752:37: E128 continuation line under-indented for visual indent -- | python/ray/_raylet.pyx:754:37: E128 continuation line under-indented for visual indent ```

[Serve] [Docs] Update metrics that Ray Serve offers in documentation

These metric exposition is lazy. This means that they will show up in the endpoint only when the metric counter/gauge is actually updated in each node. Can you check the...

[Serve] [Docs] Update metrics that Ray Serve offers in documentation

Would you be interested in help us crafting a reproducible example so we can debug this?

Hard to find example of doing middleware with Serve

How's the section? What does it miss? https://docs.ray.io/en/releases-1.9.2/serve/http-servehandle.html#enabling-cors-and-other-http-middlewares

[serve] Regression of serve DAG API

This is weird... the commit you are using is inconsistent and definitely has bugs... - PyObjScanner's self._objects is set to a dict but we ended up appending - We were...

[serve] Regression of serve DAG API

Can you try run it with `SERVE_DEPLOYMENT_HANDLE_IS_SYNC=1` (turn off async) and `SERVE_DEPLOYMENT_HANDLE_IS_SYNC=0` (new default behavior)?

[serve] Regression of serve DAG API

Hmm. The PR should be equivalent to the first one because of the sync handle block.