ray icon indicating copy to clipboard operation
ray copied to clipboard

Hard to find example of doing middleware with Serve

Open worldveil opened this issue 3 years ago • 5 comments

Hard to find examples/docs around doing middleware w/ Serve.

Was really difficult to even find that starlette integrated with Ray Serve.

No good examples. Can we point to a good example or integration path users could find? May only need to be link to external example.

Also, is this (starlette) compatible with FastAPI or no?

worldveil avatar Feb 11 '22 01:02 worldveil

How's the section? What does it miss? https://docs.ray.io/en/releases-1.9.2/serve/http-servehandle.html#enabling-cors-and-other-http-middlewares

simon-mo avatar Feb 11 '22 01:02 simon-mo

That is good. I just had a hard time finding it when searching via Google, probably because I was searching for "authentication".

Maybe we just add that term, ie "middleware, like authentication or " kind of thing, to the page you posted?.

just want it easy to find. and it's a one-line fix

worldveil avatar Feb 11 '22 02:02 worldveil

Can we also make clearer the relationship of FastAPI to starlette to newer users? Many tutorials out there reference FastAPI + Ray Serve, yet our documentation mostly calls for starlette

worldveil avatar Feb 11 '22 02:02 worldveil

thoughts here? or disagree we need to make clearer?

worldveil avatar Mar 01 '22 05:03 worldveil

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

  • If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
  • If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

stale[bot] avatar Aug 10 '22 03:08 stale[bot]

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

stale[bot] avatar Sep 20 '22 18:09 stale[bot]