dd-trace-js icon indicating copy to clipboard operation
dd-trace-js copied to clipboard

Published 20 hours ago • verified publisher icon DataDog

ESLint: Require 'use strict' header

Open watson opened this issue 9 months ago • 6 comments

What does this PR do?

Require strict mode on all CommonJS modules.

watson avatar Feb 27 '25 08:02 watson

This stack of pull requests is managed by Graphite. Learn more about stacking.

watson avatar Feb 27 '25 08:02 watson

Overall package size

Self size: 9.61 MB Deduped: 108.63 MB No deduping: 109.01 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 9.0.0 | 19.6 MB | 19.61 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.9.0 | 9.77 MB | 10.14 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.14.2 | 122.36 kB | 850.93 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | limiter | 3.0.0 | 157.92 kB | 157.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

github-actions[bot] avatar Feb 27 '25 08:02 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.61%. Comparing base (1f4d857) to head (868a0ad). Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5334      +/-   ##
==========================================
- Coverage   81.86%   81.61%   -0.25%     
==========================================
  Files         471      458      -13     
  Lines       19416    19000     -416     
==========================================
- Hits        15894    15507     -387     
+ Misses       3522     3493      -29

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Feb 27 '25 08:02 codecov[bot]

Datadog Report

Branch report: watson/strict2 Commit report: f3a10dd Test service: dd-trace-js-integration-tests

:x: 10 Failed (2 Known Flaky), 912 Passed, 0 Skipped, 19m 5.72s Total Time

:x: Failed Tests (10)

This report shows up to 5 failed tests.

  • cucumber@latest commonJS reporting via agentless dynamic instrumentation runs retries with dynamic instrumentation - integration-tests/cucumber/cucumber.spec.js - Details

    Expand for error 
    xpected 6 to equal 4

  • cucumber@latest commonJS reporting via agentless dynamic instrumentation runs retries with dynamic instrumentation - integration-tests/cucumber/cucumber.spec.js - Details

    Expand for error 
    xpected 6 to equal 4

  • jest CommonJS can run tests and report tests with the APM protocol (old agents) - integration-tests/jest/jest.spec.js - :snowflake: Known flaky - Details

    Expand for error 
    imeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/integration-tests/jest/jest.spec.js)

  • jest CommonJS can run tests and report tests with the APM protocol (old agents) - integration-tests/jest/jest.spec.js - :snowflake: Known flaky - Details

    Expand for error 
    imeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/integration-tests/jest/jest.spec.js)

  • mocha CommonJS dynamic instrumentation runs retries with dynamic instrumentation - integration-tests/mocha/mocha.spec.js - Details

    Expand for error 
    annot read properties of undefined (reading 'locals')

datadog-datadog-prod-us1[bot] avatar Feb 27 '25 08:02 datadog-datadog-prod-us1[bot]

Benchmarks

Benchmark execution time: 2025-07-08 14:23:24

Comparing candidate commit 868a0ad3f78e39c94721557dc04d08c719a89cbb in PR branch watson/strict2 with baseline commit 1f4d857a96c7b3da9e4afa3bea7bdc82fda2c907 in branch master.

Found 58 performance improvements and 0 performance regressions! Performance is the same for 1220 metrics, 45 unstable metrics.

scenario:shimmer-startup-arrow-wrap-18

  • 🟩 cpu_user_time [-44.893ms; -34.698ms] or [-9.169%; -7.087%]
  • 🟩 execution_time [-56.169ms; -47.690ms] or [-10.026%; -8.512%]
  • 🟩 instructions [-182.6M instructions; -136.9M instructions] or [-8.584%; -6.434%]
  • 🟩 max_rss_usage [-18.048MB; -16.635MB] or [-13.621%; -12.554%]

scenario:shimmer-startup-arrow-wrap-20

  • 🟩 cpu_user_time [-48.349ms; -39.045ms] or [-11.204%; -9.048%]
  • 🟩 execution_time [-61.438ms; -54.303ms] or [-12.295%; -10.867%]
  • 🟩 instructions [-200.5M instructions; -150.1M instructions] or [-9.339%; -6.990%]
  • 🟩 max_rss_usage [-20.731MB; -19.587MB] or [-15.805%; -14.933%]

scenario:shimmer-startup-arrow-wrap-22

  • 🟩 cpu_user_time [-38.517ms; -29.448ms] or [-9.584%; -7.328%]
  • 🟩 execution_time [-49.825ms; -39.546ms] or [-10.552%; -8.375%]
  • 🟩 instructions [-197.9M instructions; -161.1M instructions] or [-9.765%; -7.953%]
  • 🟩 max_rss_usage [-17.638MB; -15.882MB] or [-12.991%; -11.697%]

scenario:shimmer-startup-arrow-wrapfn-18

  • 🟩 instructions [-64.9M instructions; -60.7M instructions] or [-6.099%; -5.700%]

scenario:shimmer-startup-arrow-wrapfn-20

  • 🟩 cpu_user_time [-13.700ms; -10.032ms] or [-7.564%; -5.539%]
  • 🟩 instructions [-60.5M instructions; -56.0M instructions] or [-6.155%; -5.692%]

scenario:shimmer-startup-arrow-wrapfn-22

  • 🟩 instructions [-58.3M instructions; -54.4M instructions] or [-6.235%; -5.823%]

scenario:shimmer-startup-asyncarrow-wrap-18

  • 🟩 cpu_user_time [-48.546ms; -38.487ms] or [-9.336%; -7.401%]
  • 🟩 execution_time [-54.608ms; -47.835ms] or [-9.273%; -8.123%]
  • 🟩 instructions [-178.4M instructions; -138.4M instructions] or [-8.015%; -6.218%]
  • 🟩 max_rss_usage [-18.159MB; -16.858MB] or [-13.745%; -12.760%]

scenario:shimmer-startup-asyncarrow-wrap-20

  • 🟩 cpu_user_time [-55.475ms; -33.537ms] or [-12.311%; -7.443%]
  • 🟩 execution_time [-71.032ms; -48.735ms] or [-13.702%; -9.401%]
  • 🟩 instructions [-226.7M instructions; -173.4M instructions] or [-10.071%; -7.703%]
  • 🟩 max_rss_usage [-20.585MB; -19.605MB] or [-15.687%; -14.941%]

scenario:shimmer-startup-asyncarrow-wrap-22

  • 🟩 cpu_user_time [-41.748ms; -33.780ms] or [-9.825%; -7.950%]
  • 🟩 execution_time [-49.149ms; -42.738ms] or [-9.977%; -8.676%]
  • 🟩 instructions [-203.8M instructions; -180.0M instructions] or [-9.571%; -8.452%]
  • 🟩 max_rss_usage [-17.673MB; -16.747MB] or [-13.041%; -12.358%]

scenario:shimmer-startup-asyncdeclared-wrap-18

  • 🟩 max_rss_usage [-17.973MB; -13.801MB] or [-13.640%; -10.474%]

scenario:shimmer-startup-asyncdeclared-wrap-20

  • 🟩 cpu_user_time [-56.711ms; -41.610ms] or [-12.590%; -9.237%]
  • 🟩 execution_time [-72.625ms; -59.283ms] or [-13.951%; -11.388%]
  • 🟩 instructions [-233.3M instructions; -178.1M instructions] or [-10.415%; -7.952%]
  • 🟩 max_rss_usage [-21.079MB; -20.219MB] or [-15.992%; -15.339%]

scenario:shimmer-startup-asyncdeclared-wrap-22

  • 🟩 cpu_user_time [-36.527ms; -25.358ms] or [-8.612%; -5.979%]
  • 🟩 execution_time [-48.043ms; -40.279ms] or [-9.750%; -8.175%]
  • 🟩 instructions [-218.3M instructions; -186.9M instructions] or [-10.213%; -8.743%]
  • 🟩 max_rss_usage [-17.471MB; -16.273MB] or [-12.925%; -12.039%]

scenario:shimmer-startup-declared-wrap-18

  • 🟩 cpu_user_time [-45.888ms; -35.402ms] or [-9.350%; -7.213%]
  • 🟩 execution_time [-52.767ms; -45.662ms] or [-9.420%; -8.152%]
  • 🟩 instructions [-164.0M instructions; -125.9M instructions] or [-7.741%; -5.944%]
  • 🟩 max_rss_usage [-17.636MB; -16.418MB] or [-13.372%; -12.449%]

scenario:shimmer-startup-declared-wrap-20

  • 🟩 cpu_user_time [-60.557ms; -38.452ms] or [-13.845%; -8.791%]
  • 🟩 execution_time [-71.063ms; -50.201ms] or [-14.123%; -9.977%]
  • 🟩 instructions [-217.5M instructions; -171.4M instructions] or [-10.129%; -7.980%]
  • 🟩 max_rss_usage [-20.807MB; -19.715MB] or [-15.824%; -14.994%]

scenario:shimmer-startup-declared-wrap-22

  • 🟩 cpu_user_time [-40.290ms; -26.961ms] or [-9.924%; -6.641%]
  • 🟩 execution_time [-52.386ms; -37.679ms] or [-10.992%; -7.906%]
  • 🟩 instructions [-197.2M instructions; -149.4M instructions] or [-9.743%; -7.379%]
  • 🟩 max_rss_usage [-17.317MB; -15.545MB] or [-12.746%; -11.442%]

scenario:shimmer-startup-declared-wrapfn-18

  • 🟩 cpu_user_time [-29.234ms; -24.520ms] or [-7.480%; -6.274%]
  • 🟩 execution_time [-25.517ms; -22.158ms] or [-6.212%; -5.394%]
  • 🟩 instructions [-161.4M instructions; -152.1M instructions] or [-8.141%; -7.672%]

scenario:shimmer-startup-declared-wrapfn-20

  • 🟩 cpu_user_time [-34.683ms; -25.333ms] or [-10.247%; -7.484%]
  • 🟩 execution_time [-32.617ms; -24.351ms] or [-9.160%; -6.839%]
  • 🟩 instructions [-150.3M instructions; -142.3M instructions] or [-8.478%; -8.023%]

scenario:shimmer-startup-declared-wrapfn-22

  • 🟩 cpu_user_time [-25.816ms; -18.766ms] or [-8.325%; -6.051%]
  • 🟩 execution_time [-24.845ms; -20.089ms] or [-7.508%; -6.071%]
  • 🟩 instructions [-146.2M instructions; -134.5M instructions] or [-8.716%; -8.019%]

pr-commenter[bot] avatar Feb 27 '25 08:02 pr-commenter[bot]

I've reviewed all 344 files in the previous PR, I don't think i have the strength to do it again :/

simon-id avatar Feb 27 '25 11:02 simon-id