Omar Shrit
Omar Shrit
This is ready for merging, the tests are passing locally, will see on the CI :smiley:
@TirelessClock the code looks good, I skimmed the implementation rapidly, but I will go more into detail. Sorry for my slow review on this one. Could you add a couple...
I approved this one too quickly, I did not see the that the tests were not passing. @MarkFischinger could you try to run the tests locally ? I would be...
@MarkFischinger give it a try, what I find weird is that, when we tested this separately the time was way faster, while here it looks much slower than the original...
closing this one as it is no longer needed since we found a better solution last month
Here is another one, with a benchmark ```c++ #include #include int main() { arma::mat output = arma::randu(10, 10); arma::mat output_2 = output; output.print("original matrix"); double ratio = 0.2; auto start_mlpack...
better implementations are welcomed :smile:
@MarkFischinger the idea is not to find a better implementation, but instead is to get rid of the usage of the transform function from armadillo because we can not no...
btw, I really like the fact of using the template parameter as a function pointer. This is really a nice way of doing it :100: ```c++ // Function to time...
@rcurtin if we agree on using the Padé Approximation, @MarkFischinger would you by then open a PR ? and replace the current solution with Padé ? Also would you do...