Omar Shrit
Omar Shrit
Agreed this is a cool feature to merge before releasing mlpack 4, @zoq great work :100:
I have marked this for mlpack 4. If you got a chance to merge it before that would be great :+1:
@RUrlus thanks for putting effort to design `caram`, it is really nice project, I personally think it is very nice to have `carma` to convert from Numpy matrices to Armadillo....
@rcurtin Great work on this. I wanted to review it this weekend, but I had no chance. I was facing some DNS issues. This is really huge :rocket: :100:
I disagree with why `const arma::mat& data` is making a copy of the data. it is passing it by reference, using the exact memory location. Try to use `arma::mat data`...
@zoq do we close this? to be honest, the PR looks so outdated that we can re-write it from scratch if necessary.
Probably we will close this one before mlpack 5.0
I think it is no longer necessary after the refactoring with the v-table, sorry I did not see your comment earlier this year
@rodonguyen feel free to collaborate with @rcurtin on this. @rcurtin what do you think?
@arthiondaena sorry for our slow response on this, your PR just went stale so I have reopened it. @arthiondaena are you still interested in continuing working on this?