subham sarkar
subham sarkar
Can you share the minimum steps to test the changes made in the "How to test this PR locally" section of the PR description?
Yes, let's wait for @aliabbas-elastic before merging
Nice find. Can you also open a PR for the integrations repo? See: https://github.com/search?q=repo%3Aelastic%2Fintegrations+path%3A%2F%5Epackages%5C%2Fapache%5C%2Fkibana%5C%2F%2F+apache2&type=code
Please add an entry to the changelog.
Changes LGTM. However, I would like another member of my team to review this as well before we merge.
@herrBez CI is passing. Let's merge?
@harnish-elastic You can remove the changes in *.bat because I think the issue that we were facing is already addressed by this commit: https://github.com/elastic/beats/commit/f87a5922620bea5afc9ebfc5f320871f7652f4cd
> @shmsr, This PR should fix the bug you mentioned in https://github.com/elastic/beats/pull/40411/files#r1740184901. My testing was done on the s390x platform but from what I have been able to find s390x...
Support for SSL/ TLS was added for metricbeat's Redis module but not in the filebeat input. See: https://github.com/elastic/beats/pull/35240 (metricbeat TLS support) See: https://github.com/elastic/beats/issues/39412 (open issue to add filebeat input Redis...
Sure, @ycombinator!