beats icon indicating copy to clipboard operation
beats copied to clipboard

filebeat/module/apache: Rename the field `apache2.module.error` to `apache.module.error`

Open herrBez opened this issue 1 year ago • 9 comments

Proposed commit message

Rename field apache2.module.error to apache.module.error in the Dashboard

Checklist

  • [x] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

  • #39480

Use cases

Screenshots

image

The original saved search uses apache2.error.module, while the correct field apache.error.module (added by me) shows that it is actually populated with a meaningful value.

Logs

herrBez avatar May 09 '24 06:05 herrBez

This pull request doesn't have a Team:<team> label.

botelastic[bot] avatar May 09 '24 06:05 botelastic[bot]

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @herrBez? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar May 09 '24 06:05 mergify[bot]

Nice find. Can you also open a PR for the integrations repo? See: https://github.com/search?q=repo%3Aelastic%2Fintegrations+path%3A%2F%5Epackages%5C%2Fapache%5C%2Fkibana%5C%2F%2F+apache2&type=code

shmsr avatar May 09 '24 06:05 shmsr

Please add an entry to the changelog.

shmsr avatar May 09 '24 06:05 shmsr

Thank you. I think I addressed both points now :) . I am on it for the integration's PR

herrBez avatar May 09 '24 07:05 herrBez

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-05-09T07:24:58.495+0000

  • Duration: 159 min 47 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 8428
Skipped 773
Total 9201

:green_heart: Flaky test report

Tests succeeded.

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine avatar May 09 '24 07:05 elasticmachine

Changes LGTM. However, I would like another member of my team to review this as well before we merge.

shmsr avatar May 09 '24 07:05 shmsr

@shmsr @devamanv : I think this can be merged in beats as well?

ishleenk17 avatar May 24 '24 05:05 ishleenk17

I see some failures in the build, but I hardly believe they are related with the change introduced here: https://github.com/elastic/beats/pull/39481/checks?check_run_id=25345121364 .

herrBez avatar May 24 '24 05:05 herrBez

@herrBez CI is passing. Let's merge?

shmsr avatar May 28 '24 07:05 shmsr

Done. Thank you for the help and support!

herrBez avatar May 28 '24 08:05 herrBez