beats icon indicating copy to clipboard operation
beats copied to clipboard

[Metricbeat] [Statsd] Add support for Graphite series 1.1.0+ tags

Open tehbooom opened this issue 1 year ago • 4 comments

Proposed commit message

Added conditional to check if statsd metric contains , or ; and split accordingly

Checklist

  • [X] My code follows the style guidelines of this project
  • [X] I have commented my code, particularly in hard-to-understand areas
  • [X] I have made corresponding changes to the documentation
  • [X] I have made corresponding change to the default configuration files
  • [X] I have added tests that prove my fix is effective or that my feature works
  • [X] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

  • Closes #39473

Use cases

Screenshots

Screenshot 2024-05-17 at 11 14 46 AM

Logs

{
  "_index": ".ds-metricbeat-8.15.0-2024.05.17-000001",
  "_id": "iNaPho8Bf8HHEaVjdnAn",
  "_version": 1,
  "_score": 0,
  "_source": {
    "@timestamp": "2024-05-17T12:38:09.825Z",
    "service": {
      "type": "statsd"
    },
    "statsd": {
      "envoy_listener_worker_downstream_cx_active": {
        "value": 0
      }
    },
    "labels": {
      "envoy.worker_id": "10",
      "envoy.listener_address": "0.0.0.0_9001"
    },
    "ecs": {
      "version": "8.0.0"
    },
    "host": {
      "name": "mbp"
    },
    "agent": {
      "name": "mbp",
      "type": "metricbeat",
      "version": "8.15.0",
      "ephemeral_id": "41c29b63-8a18-4387-9879-a1b212dbcf8a",
      "id": "a934cbff-9d5b-4b73-84dd-363af4de9d23"
    },
    "metricset": {
      "name": "server"
    },
    "event": {
      "dataset": "statsd",
      "module": "statsd"
    }
  }
}

tehbooom avatar May 17 '24 15:05 tehbooom

This pull request does not have a backport label. If this is a bug or security fix, could you label this PR @tehbooom? 🙏. For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

mergify[bot] avatar May 17 '24 15:05 mergify[bot]

Can you also please update the changelog?

ritalwar avatar May 20 '24 07:05 ritalwar

Hi @aliabbas-elastic , Can we verify these changes? I've opened an issue for it here. cc: @lalit-satapathy

ritalwar avatar May 23 '24 05:05 ritalwar

Hi @aliabbas-elastic , Can we verify these changes? I've opened an https://github.com/elastic/beats/issues/39681 for it here.

@ritalwar Ok I'll look into it

ali786XI avatar May 23 '24 06:05 ali786XI

@aliabbas-elastic, could you please do one round of testing as well so we can merge this?

ritalwar avatar May 29 '24 07:05 ritalwar

Yes, let's wait for @aliabbas-elastic before merging

shmsr avatar May 29 '24 07:05 shmsr