subham sarkar
subham sarkar
Given the extensive size of the PR, reviewing all the changes thoroughly might pose a challenge. However, Kush and I have diligently gone through it, addressing numerous bugs along the...
> Approving on testing side. Refer [here](https://github.com/elastic/obs-infraobs-team/issues/1378#issuecomment-2056704279) for the testing comments Thanks @aliabbas-elastic!
The related package was upgraded in this PR: https://github.com/elastic/beats/pull/35289 and the fix is available [email protected]+ Let us know if the fix addresses the issue. Meanwhile, I will close this issue...
> > Also, found a couple of more bugs with this code. Should I push them to this PR itself? > > Yes please. @dominikh Give it a look. I've...
> > > Also, found a couple of more bugs with this code. Should I push them to this PR itself? > > > > > > Yes please. >...
> Thanks. I've cherry-picked [2dee2d9](https://github.com/dominikh/go-tools/commit/2dee2d955f0cdf4cf4da62a12b5008df3c267a7c). I didn't apply [a31684b](https://github.com/dominikh/go-tools/commit/a31684beb6154ac223653a53a5ded77e4d06a5f9) because "inline comments" aren't the correct way to mark identifiers as deprecated. https://github.com/golang/go/wiki/Deprecated explicitly states that it should be a paragraph...
@belimawr Shall I approve it? If you are planning to merge this, I'll approve as the backport changes looks fine.
Are we adding the tests that @gpop63 suggested? If yes, then I'll wait for the changes and then approve. If no, then I'll approve this PR right away; the changes...
> Thank you all for the help and the patience! After the merge I noticed we did not add an entry in the release notes. Should we add one? Yes,...
> Hi, how should we proceed? By opening a new PR? I tried committing in my branch but this PR did not get the update. > > (BTW the release...