Michael Shilman

Results 773 comments of Michael Shilman

@larsrickert Sorry I missed this one. Will look later today!

@larsrickert I haven't had a formal discussion with the team but initial sentiment from talking to a few people is that we should move controls & source handling into the...

Hi @larsrickert, can you please add the following flag: ```js parameters: { docs: { source: { addonPanel: false, }, }, } ``` This way users can opt out of the...

Oof. I'm actually not too familiar with that aspect of things. @ndelangen can you please help?

@larsrickert Tested and it's working well. I'll take another pass at things tomorrow and try to get it merged. Great job!!

@larsrickert not so comfortable with the current parameter implementation. I have a cleaner solution with a worse user API. Need to figure that out, sorry for the delays. I'll update...

@larsrickert i discussed with @yannbf and @ndelangen and the current parameter approach won't cut it. i'm going to reimplement it now with a worse API and then get it merged....

@larsrickert I've opened a PR on top of this one for your review. Please merge if you're OK with it, or we can discuss the changes there. https://github.com/storybookjs/storybook/pull/29791 I've also...

This is actually a regression. At some point all of the themes got added back into the doc blocks, so the bundle size is much larger than it should be....