Michael Shilman

Results 773 comments of Michael Shilman

Thanks @tobiasdiez @chakAs3 for being on top of this. 🙏

This is an issue in `react-docgen`. https://github.com/reactjs/react-docgen/issues/905 Please help fix the issue there or, if you can't wait for the fix, please use `react-docgen-typescript`, which is still supported in Storybook....

@Charismara Is that issue related to Readonly properties or is it about including properties from `node_modules`?

@ArnaudBarre We'd love to use this for Storybook's React Native Web Vite support, which involves `node_modules` shenanigans due to how the RN ecosystem publishes flows sources etc. Is there any...

@ArnaudBarre OK took me a second to understand how it's a breaking change, but I see now! 🙀 We can work around this somehow, so no pressure. But please know...

If anybody can provide a reproduction on `latest` (currently 8.3.6) we'd be happy to take a look!

Olé!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.4.0-alpha.32 containing PR #15874 that references this issue. Upgrade today to the `@next` NPM tag to try it out! ``` npx sb upgrade --prerelease ``` Closing...

@saulodias @ThibaudAV any ideas why the fix didn't work?

Thanks @wesself ! Closing this until we get a reproduction 🙏