Michael Shilman

Results 773 comments of Michael Shilman

In 6.0 we've moved to a parallel theming structure for docs: https://github.com/storybookjs/storybook/blob/next/addons/docs/docs/theming.md#storybook-theming

I believe docs is dynamically themable but Storybook UI is not cc @ndelangen

@hipstersmoothie OK I misunderstood the issue. In `master`, docs is themed by the `options.theme` parameter per this issue. In `next`, docs is themed via the `docs.theme` parameter per https://github.com/storybookjs/storybook/pull/10114. How...

@tmeasday in that case either #10114 was wrong and we should switch to `globalArgs` (which is possible because we haven't released 6.0 yet), or we should forego dynamic theming in...

@probablyup we'll take a look at things this week. i don't think we'll block the release for it, but depending on how broken it is it's possibly something that we...

FYI, this PR needs more work. The tests are failing due to some breaking change in the dependencies.

@sno6 Fixed in Storybook 10 which was just released. Closing!

:rocket: PR was released in [`v5.0.0-next.4`](https://github.com/storybookjs/addon-svelte-csf/releases/tag/v5.0.0-next.4) :rocket:

Yes, this scenario is supposed to work in 7.0. @william-will-angi do you have a repro handy that you can share? @ndelangen did you test this case in your 7.0 composition...