Brendan Forster

Results 633 comments of Brendan Forster

Hi all. Please stop asking for me to assign this task before I've had a look at it. It's not clear to me what this change would look like, so...

Resolved via https://github.com/up-for-grabs/up-for-grabs.net/pull/4513

Resolved via #4283

@CxGainz apologies for the delay in getting to this - the changes seem fine, but it feels weird to be doing this processing each time this method runs, and I...

`npm run prettier-fix` will fix this: ``` Checking formatting... [warn] javascripts/projectsService.js [warn] Code style issues found in the above file. Run Prettier with --write to fix. ```

@S1rlvk please include some screenshots or context to go with this change - without additional context I plan to close this PR out

Closing this out due to inactivity. Please submit a new PR if you still wish to have this change contributed.

> Currently, on the UpForGrad project page, clicking on a project name most of the times it directly opens the live website and in some cases it opens github repo....

Closing this out for now as I don't believe this is the right approach. See previous thread for scenario to test, and ensure the approach works well when the viewport...

> i've swtiched the favicons to new ones that someone posted on the issues. I know it's been a while since this PR was opened, but looking at the diff...