Brendan Forster

Results 633 comments of Brendan Forster

Also dropping the `Windows` label here as this problem isn't limited to Windows.

We probably need to think about how small the current commit form is before we can show any fancy UI here. Related issue: #1646

@iAmWillShepherd could there be something in the problem repository and commits like this that are different to your setups? https://github.com/vczh-libraries/GacUI/commit/92945be6a7fe72c037409cb60372e8ca5be3975f

Confirmed the problem commit https://github.com/vczh-libraries/GacUI/commit/92945be6a7fe72c037409cb60372e8ca5be3975f does not render correctly in Desktop for Windows _and_ macOS, so I think we need to figure out a way to drop this constraint on...

@iAmWillShepherd yeah, this basically means encoding detection and/or overriding support not unlike #1607

@vczh this is something I looked into ages ago, but it didn't eventuate: https://github.com/desktop/desktop/pull/634

@songshinyoung opened #7671 to indicate that this problem is still noticeable, and I checked one of the sample commits from earlier https://github.com/vczh-libraries/GacUI/commit/92945be6a7fe72c037409cb60372e8ca5be3975f and confirmed this is still an issue on...

@sk74575 opened #7733 which overlaps with this: > when i was write to korean it doen't work i think my program problem app wasn't use utf-8 so help me

@gmikhail opened #7731 which overlaps with this: > ## Steps to Reproduce > 1. `Add the file with cyrillic text and Windows-1251 encoding` > 2. `See the commit preview`

@ntsoftabc opened #7632 which is potentially in this same vein > ## Steps to Reproduce > 1. `Add some Chinese/Japanese characters for comments` > 2. `Can Not display(Unreadable for humans)`