Brendan Forster

Results 633 comments of Brendan Forster

@sguthals nice find! For those who don't know, the repo has some [specific instructions](https://github.com/github/visualstudio#build) for initializing: ``` git clone https://github.com/github/VisualStudio cd VisualStudio git submodule init git submodule deinit script git...

Going to look at using https://github.com/felixrieseberg/electron-wix-msi to see if it addresses these issues.

There's a few technical constraints off the top of my head that need to be dealt with alongside the UI/UX concerns for multiple account support: - permissions to a repository...

@MCF thanks for the report. I've been able to reproduce this, and I think it's down to how we handle the unborn repository. The behaviour for this button is in...

A rough patch for this: ```diff diff --git a/app/src/ui/toolbar/push-pull-button.tsx b/app/src/ui/toolbar/push-pull-button.tsx index ac499b989..2c6370f1e 100644 --- a/app/src/ui/toolbar/push-pull-button.tsx +++ b/app/src/ui/toolbar/push-pull-button.tsx @@ -68,7 +68,8 @@ export class PushPullButton extends React.Component { // open the...

@koenpunt thanks for this report! I was hoping our worktrees wouldn't get caught up in these checks, but I guess we need to tweak or BranchPruner logic to be worktree-aware....

@sylae this reminds me of https://github.com/desktop/desktop/issues/557 which might overlap here. I haven't had a chance to test this recently, but if you're interested in helping understand what the new Electron...

@sylae can you run `git status --untracked-files=all --branch --porcelain=2` instead of just plain `git status`? That contains extra information that Desktop uses to render it's list of changes, and I...

I've been able to reproduce this in a test. It relies on [`stat-mode`](https://www.npmjs.com/package/stat-mode) for a bit of readability: ```diff diff --git a/app/test/unit/git/commit-test.ts b/app/test/unit/git/commit-test.ts index b5ac688e5..18002c38c 100644 --- a/app/test/unit/git/commit-test.ts +++ b/app/test/unit/git/commit-test.ts...