up-for-grabs.net icon indicating copy to clipboard operation
up-for-grabs.net copied to clipboard

favicon view fixed

Open c9ssio opened this issue 2 years ago • 2 comments

i've swtiched the favicons to new ones that someone posted on the issues.

c9ssio avatar Nov 24 '22 02:11 c9ssio

:wave: I'm a robot checking the state of this pull request to save the human reviewers time. I don't see any changes under _data/projects/ so I don't have any feedback here.

As you make changes to this pull request, I'll re-run these checks.

shiftbot avatar Aug 27 '23 18:08 shiftbot

i've swtiched the favicons to new ones that someone posted on the issues.

I know it's been a while since this PR was opened, but looking at the diff changes it seems like the biggest change here is a white background on the icon. This is how it looks for the default setup in Chrome on macOS:

Screenshot 2023-08-27 at 4 08 24 PM

When I switch this over to dark mode here's what I get:

Screenshot 2023-08-27 at 4 09 22 PM

Firefox in dark mode also has the same effect:

Screenshot 2023-08-27 at 4 09 58 PM

Was this what we were trying to fix @c9ssio? Without more context I'm guessing this was what we were trying to fix but it's all very hazy to me...

shiftkey avatar Aug 27 '23 19:08 shiftkey