sh2 comments

Results 187 comments of

sh2

utilize hugo boilerplates for docs

ref to https://github.com/envoyproxy/gateway/pull/3652

feat: add host-infra provider support

> @shawnh2 do we have built any e2e tests for host mode? and we need a user-facing docs for a quickstart and a little bit words about its scenarios will...

fix: ratelimit not working with both headers and cidr matches

/retest

Add hook points support in conformance test suite

Assign myself, since I've been working on something that is quite similar to this issue as well. I will post the initial design of this here once it's done. /assign

chore: clean up gatewayapi v1alpha2 helpers

/retest

Ratelimiting doesn't work with both clientSelectors (i.e. headers and sourceCIDR) enabled

Looks weird, can you share the output of `egctl config rl -n envoy-gateway-system` ?

Ratelimiting doesn't work with both clientSelectors (i.e. headers and sourceCIDR) enabled

Thanks for reporting this, it is indeed a bug. Though we have created RL actions for both Headers & CIDR correctly, https://github.com/envoyproxy/gateway/blob/cbd92e2a423de036d5c8b9db530f0a66d5ce47f9/internal/xds/translator/ratelimit.go#L142 but doing wrong when building RL Descriptors.