gateway icon indicating copy to clipboard operation
gateway copied to clipboard

feat: add host-infra provider support

Open shawnh2 opened this issue 1 year ago • 1 comments

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

ref #1393

shawnh2 avatar Oct 19 '24 05:10 shawnh2

Codecov Report

Attention: Patch coverage is 32.79133% with 248 lines in your changes missing coverage. Please review.

Project coverage is 65.77%. Comparing base (544bd9c) to head (36a9f17). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/certgen.go 17.54% 37 Missing and 10 partials :warning:
internal/infrastructure/host/proxy_infra.go 14.28% 42 Missing :warning:
internal/infrastructure/host/infra.go 20.00% 33 Missing and 3 partials :warning:
internal/crypto/cert_load.go 0.00% 31 Missing :warning:
internal/infrastructure/manager.go 0.00% 19 Missing :warning:
internal/globalratelimit/runner/runner.go 0.00% 18 Missing :warning:
internal/xds/server/runner/runner.go 0.00% 18 Missing :warning:
internal/gatewayapi/runner/runner.go 36.00% 16 Missing :warning:
internal/infrastructure/common/proxy_args.go 84.21% 4 Missing and 2 partials :warning:
api/v1alpha1/envoygateway_helpers.go 33.33% 4 Missing :warning:
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4481      +/-   ##
==========================================
- Coverage   65.95%   65.77%   -0.18%     
==========================================
  Files         203      209       +6     
  Lines       31154    31352     +198     
==========================================
+ Hits        20547    20622      +75     
- Misses       9420     9533     +113     
- Partials     1187     1197      +10     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 19 '24 08:10 codecov[bot]

hey @shawnh2 when we write docs, we should probably highlight that standalone mode is still experimental and not meant for production yet, and not all features work out of the box (like global ratelimit)

arkodg avatar Oct 22 '24 01:10 arkodg

@shawnh2 do we have built any e2e tests for host mode? and we need a user-facing docs for a quickstart and a little bit words about its scenarios

Xunzhuo avatar Oct 22 '24 03:10 Xunzhuo

@shawnh2 do we have built any e2e tests for host mode? and we need a user-facing docs for a quickstart and a little bit words about its scenarios

will add user-facing doc & e2e test as a follow-up.

shawnh2 avatar Oct 22 '24 05:10 shawnh2

@shawnh2 please rebase to make CI happy.

zirain avatar Oct 22 '24 11:10 zirain