Shan E Ahmed Raza

Results 47 comments of Shan E Ahmed Raza

Build failing due to missing dependencies https://github.com/conda-forge/albumentations-feedstock/pull/22 Fixed applied in this PR https://github.com/regro-cf-autotick-bot/albumentations-feedstock/pull/1

This might be a good resource https://github.com/Peter554/StainTools https://tia-toolbox.readthedocs.io/en/latest/usage.html#stain-extraction https://tia-toolbox.readthedocs.io/en/latest/usage.html#stain-normalization

Please check recommendations here to fix errors with pre-commit and deepsource https://deepsource.io/gh/TissueImageAnalytics/tiatoolbox/run/b55650f7-a968-46b3-aa2d-b54d3d9f5ee2/python/PYL-W0102

Travis errors will be fixed in #384

I think we should follow [this structure](https://scikit-image.org/docs/stable/api/skimage.registration.html) for our registration module. @John-P what do you think?

Closing this PR as this has been resolved in separate PRs.

@vqdang @mostafajahanifar @John-P this is ready for review. I have added model trained on CoNiC as well.

> Looks good. I like Dang's suggestion of moving the spatially constrained layer into its own class (easier to re-use), but otherwise good. Happy either way. I had discussed this...

> > > I don't know how to react to this message (see screen shot) Hi @DavidBAEpstein, you do not need to worry about this. I will do this once...

Looks good to me. I agree with John's comment on using opencv for morphological processing.