tiatoolbox icon indicating copy to clipboard operation
tiatoolbox copied to clipboard

NEW: Add SCCNN Cell Detection Architecture

Open shaneahmed opened this issue 2 years ago • 2 comments

  • Add SCCNN architecture.

shaneahmed avatar Jul 27 '22 09:07 shaneahmed

Codecov Report

Merging #434 (3ef7ab3) into develop (1ba4272) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #434      +/-   ##
===========================================
+ Coverage    98.59%   98.62%   +0.02%     
===========================================
  Files           58       59       +1     
  Lines         5784     5872      +88     
  Branches      1047     1049       +2     
===========================================
+ Hits          5703     5791      +88     
  Misses          69       69              
  Partials        12       12              
Impacted Files Coverage Δ
tiatoolbox/models/architecture/micronet.py 100.00% <ø> (ø)
tiatoolbox/models/architecture/sccnn.py 100.00% <100.00%> (ø)
tiatoolbox/models/architecture/unet.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 27 '22 09:07 codecov[bot]

@vqdang @mostafajahanifar @John-P this is ready for review. I have added model trained on CoNiC as well.

shaneahmed avatar Aug 09 '22 14:08 shaneahmed

Looks good. I like Dang's suggestion of moving the spatially constrained layer into its own class (easier to re-use), but otherwise good. Happy either way.

I had discussed this with Dang earlier. This meant retraining the model separately. So we decided not to do this.

shaneahmed avatar Aug 26 '22 10:08 shaneahmed