tiatoolbox icon indicating copy to clipboard operation
tiatoolbox copied to clipboard

NEW: RegistrationConfig Class

Open ruqayya opened this issue 2 years ago • 4 comments

This class will initialize the parameters required for the DFBR registration.

ruqayya avatar Jun 30 '22 12:06 ruqayya

Please check recommendations here to fix errors with pre-commit and deepsource https://deepsource.io/gh/TissueImageAnalytics/tiatoolbox/run/b55650f7-a968-46b3-aa2d-b54d3d9f5ee2/python/PYL-W0102

shaneahmed avatar Jun 30 '22 15:06 shaneahmed

Travis errors will be fixed in #384

shaneahmed avatar Jun 30 '22 15:06 shaneahmed

Codecov Report

Merging #385 (cd811f0) into develop (1f3e07d) will decrease coverage by 0.67%. The diff coverage is 48.61%.

@@             Coverage Diff             @@
##           develop     #385      +/-   ##
===========================================
- Coverage    99.60%   98.93%   -0.68%     
===========================================
  Files           55       57       +2     
  Lines         5367     5439      +72     
  Branches       962      970       +8     
===========================================
+ Hits          5346     5381      +35     
- Misses           9       45      +36     
- Partials        12       13       +1     
Impacted Files Coverage Δ
tiatoolbox/tools/registration/wsi_registration.py 47.88% <47.88%> (ø)
tiatoolbox/tools/registration/__init__.py 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 04 '22 00:07 codecov[bot]

I think we should follow this structure for our registration module. @John-P what do you think?

shaneahmed avatar Jul 04 '22 08:07 shaneahmed

Closing this PR as this has been resolved in separate PRs.

shaneahmed avatar Oct 10 '22 08:10 shaneahmed