Samuel Farrens

Results 13 comments of Samuel Farrens

Thanks for the feedback @paquiteau, I am still playing around with this PR, but I like these suggestions. I will play around some more this week and ping you when...

Sounds like a good plan to me @paquiteau! Some other points to consider: - Many Python projects are moving away from using `setup.py` and `setup.cfg` to exclusively using a `pyproject.toml`...

Sorry I missed that, but since this is tied to the configuration of Black I think point 8 is linked to point 5 and should probably be done in conjunction.

@zaccharieramzi will you have any time to look into this at some point?

@MorganSchmitz This is a nice idea, but since `linear` is a positional argument it would mean changing every call to this class in every package that uses it. An alternative...

@MorganSchmitz Yes, that should work fine, but I think it might be better to make `None` the default for weights so that an error (or warning) can be raised if...

@chaithyagr Indeed. I will probably hold off opening a PR for this until we have a clear plan for how we want to handle the cost contribution from proximity operators.

@zaccharieramzi are you planning a PR for this issue?

@zaccharieramzi I think having a diverse set of reconstruction algorithms would be useful regardless. So if you have already implemented it then feel free to open a PR.

@zaccharieramzi are you still planning a PR for this algorithm?