ModOpt icon indicating copy to clipboard operation
ModOpt copied to clipboard

Pyproject code refactor

Open sfarrens opened this issue 3 years ago • 2 comments

Summary

This PR refactors the codebase to simplify maintenance and development.

  • Removed setup.py and setup.cfg and added pyproject.toml
  • Removed redundant files/directories: .pylintrc, .pyup.yml, develop.txt, docs/requirements.txt, notebooks
  • Ran Black on modopt (i.e. only style changes, no changes to code or tests)
  • Updated docs: removed redundant notebook tools, cleaned up
  • Updated manifest
  • Simplified CI tests: several tests can now be run manually rather that being triggered for each commit, only the latest version of Python will run automatically

To Do

  • [ ] Update README.md and installation instructions
  • [ ] Check that new CI/CD works correctly
  • [ ] Additional checks

sfarrens avatar Mar 16 '23 17:03 sfarrens

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@2d7da27). Click here to learn what that means. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             develop     #289   +/-   ##
==========================================
  Coverage           ?   91.48%           
==========================================
  Files              ?       44           
  Lines              ?     2372           
  Branches           ?        0           
==========================================
  Hits               ?     2170           
  Misses             ?      202           
  Partials           ?        0           
Flag Coverage Δ
unittests 91.48% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Mar 16 '23 17:03 codecov-commenter

Thanks for the feedback @paquiteau, I am still playing around with this PR, but I like these suggestions. I will play around some more this week and ping you when the PR is ready for final review.

sfarrens avatar Mar 20 '23 16:03 sfarrens