Özkan Sezer

Results 569 comments of Özkan Sezer

> Isn't ogg needed as a dependency for opus? Yes, it is. Note that opus framework here in SDL_mixer(s Xcode is a combination of opus and opusfile, possibly for simplicity...

May I suggest something like the following to make it buildable in C90 mode and avoid errors if ELOOP isn't available: ```diff diff --git a/src/physfs_platform_libretro.c b/src/physfs_platform_libretro.c index 58694ba..dcc0c87 100644 ---...

Do you need the dynapi functionality of SDL? If you don't, insert a similar disabler for ohos around [here](https://github.com/OpenMinecraft-Dev/SDL/blob/main/src/dynapi/SDL_dynapi.h#L50-L51).

> Does it work? I changed the commit message Hmph. It still seems to run all the workflows. @madebr: Is the filtering correct?

> . No because pull requests creators cannot sneakily disable a workflow. > > So yes, the problem was already present. Actually that's a good thing and not a problem....

Minor thing: I got this bogus warning from gcc: ``` src/gpu/vulkan/SDL_gpu_vulkan.c: In function 'VULKAN_PrepareDriver': src/gpu/vulkan/SDL_gpu_vulkan.c:11975: warning: 'instancePfns' may be used uninitialized in this function ``` Something like the following cures...

BTW, RTLD_DEFAULT need not be defined as NULL, it is implementation defined as far as I recall.

BTW: Should we allow statically linking libgme, which is LGPL, into SDL_mixer anyway??? (Same question for mpg123.)

Here is a tidy-up patch that makes things build for me: [dsu.patch](https://github.com/user-attachments/files/23145979/dsu.patch) - DSU_ReceiverThread() must be marked as SDLCALL - the `lib` pragma is for MSVC only: others need ws2_32...