Özkan Sezer

Results 570 comments of Özkan Sezer

This patch is wrong: it zeroes `comment_list_length` at the wrong place, and may result in memory leaks. See https://github.com/nothings/stb/pull/1557#issuecomment-1848997604 for a combined solution.

Does the issue show itself with current quakespasm git master?

That's great, thanks for testing! So the additional problem you're describing at https://github.com/andrei-drexler/ironwail/issues/242#issuecomment-1678643170 is probably ironwail-specific.

> Upstream seems like they will fix this: [sezero#56](https://github.com/sezero/quakespasm/issues/56) _will fix_ is a big claim: We are not sure about any subtle adverse side effects of the patch in question.

@icculus: Do you mean something like the following? (On top of the existing patch.) ```diff diff --git a/src/core/windows/SDL_windows.h b/src/core/windows/SDL_windows.h index ac6def6..3842e08 100644 --- a/src/core/windows/SDL_windows.h +++ b/src/core/windows/SDL_windows.h @@ -76,6 +76,19 @@...

I rebased the patch to current SDL2 branch and applied my patch on top of it. @skeeto: Are you good with this? @icculus: After merge, do we want this in...

> Let's let the build checks finish just in case, then merge this, and pull this into SDL3, too. SDL3 will need porting to, at least because SDL_main is different...

Cherry-picked to release-2.28.x branch as 078e817cebec59e5c239e130223267a11cb87aee