Özkan Sezer
Özkan Sezer
Any chance that the SDL_mixer issue you linked is related to the following? https://github.com/libsdl-org/sdl12-compat/issues/215#issuecomment-1271439552 https://github.com/libsdl-org/SDL_mixer/commit/4c47f6f3eb2fe180c9acefea91cc02ae9ba20e68 https://github.com/libsdl-org/SDL_mixer/commit/615882306946a840a9725eb74e8c247dc43f9518
PING?
PING?
Is the following OK for sdl2-compat? ```diff diff --git a/src/sdl2_compat.c b/src/sdl2_compat.c index 16c6d20..3805f63 100644 --- a/src/sdl2_compat.c +++ b/src/sdl2_compat.c @@ -5356,9 +5356,12 @@ SDL_AudioStreamFlush(SDL2_AudioStream *stream2) return SDL3_FlushAudioStream(stream2 ? stream2->stream3 : NULL);...
SDL_mixer uses SDL_MIX_MAXVOLUME a lot. Maybe Mix_VolumeMusic, Mix_MasterVolume, struct Mix_Chunk, struct _Mix_Channel and all others should be converted to use floats? Possibly a lot of work, but either way SDL_mixer...
> > Is the following OK for sdl2-compat? > > I would call it SDL2_MIX_MAXVOLUME, not SDL3, since technically this is the SDL2 value, but otherwise looks okay to me....
> As for SDL_mixer, let's just throw in the right conversion when making calls into SDL3 and otherwise leave it alone for now. We haven't really had time to rethink...
> > As for SDL_mixer, let's just throw in the right conversion when making calls into SDL3 and otherwise leave it alone for now. We haven't really had time to...
> Which compiler are you using that doesn't define `__has_extension` on macOS? I guess it's GCC? It may be a clang version e.g. on linux being used as a cross-compiler....
Do you have a patch? CC: @andrei-drexler, @ericwa