highfive

highfive copied to clipboard

Should we check the diffs whenever new code is committed?

2

In servo/servo#11267, the author modified the stuff inside `python`, and I was notified by highfive when the PR was opened. Later, new commits were added, where the author went for...

wafflespeanut

Consider not commenting about new commits if the last comment was made by highfive

1

I feel bad for spamming people when pushing little fixups :-) The worst case, that could be a needed rebase, is addressed by bors comment about the bitrot.

emilio

Add the S-needs-code-changes if travis build fails

18

jdm

Approver is ignored; comment author is marked reviewer

1

I've done `@bors-servo: r=Ms2ger` in PRs recently and had highfive assign me. I can't see any reason why this happens from reading the code; I've verified the regex in http://regexpal.com/,...

jdm

Post a link to the raw WPT log and reftest analyzer when appropriate

1

When homu reports a WPT testsuite failure, we should post a comment linking to the raw log. If it's test-css, we should link to the reftest analyzer tool, too: http://hoppipolla.co.uk/410/reftest-analyser-structured.xhtml

jdm

#103 was supposed to fix #66, but highfive doesn't work for both the cases [(1)](https://github.com/servo/servo/pull/10901#issuecomment-215932461) & [(2)](https://github.com/servo/servo/pull/10975#issuecomment-216395531) sometimes. But, it also [does work](https://github.com/servo/servo/pull/10980#event-648324458) sometimes. I'm not sure whether this is...

wafflespeanut

Consider putting WPT test failures into a gist if there are too many

6

It shouldn't be hard to create a gist if the report is more than, let's say, 30 lines, and it would prevent overloading the thread too much. Ideally the report...

emilio

Ask if the PR author would like a suggestion for something else to work on when a PR is merged

4

jdm

IRC github bot not configured for this repo?

2

Just opened #94, and it didn't show up in IRC.

emilio

i.e. https://github.com/servo/servo/blob/master/tests/wpt/README.md#updating-test-expectations

jdm