highfive icon indicating copy to clipboard operation
highfive copied to clipboard

Consider putting WPT test failures into a gist if there are too many

Open emilio opened this issue 8 years ago • 6 comments

It shouldn't be hard to create a gist if the report is more than, let's say, 30 lines, and it would prevent overloading the thread too much.

Ideally the report could also contain how many tests passed, how many failed and how many timed out.

emilio avatar Apr 24 '16 22:04 emilio

I'm ambivalent about this. The whole point of having highfive show the WPT test failures is to make our life easier (i.e., we don't have to navigate a couple of pages to get the test results) :smile:

wafflespeanut avatar Apr 25 '16 03:04 wafflespeanut

I think we should truncate the test log output instead, if there are more than 15 failures or so.

KiChjang avatar Apr 25 '16 04:04 KiChjang

A gist seems like a good compromise to me, since it's only a single link away versus the status quo of many possible links to choose from.

jdm avatar Apr 25 '16 13:04 jdm

Okay, then we can limit the posted log (to 20 lines or something), and link to the gist if it gets exceeded. In such cases, we could also go for showing only the test names and results in the PR, and putting other details into the gist.

wafflespeanut avatar Apr 25 '16 15:04 wafflespeanut

I'm not super interested in a doing a bunch of processing on the output - if 500 tests fail, it would still be a nuisance to scroll through just the test names. I'd say post the output inline if it's <30 lines, otherwise make a gist and post the link instead.

jdm avatar Apr 25 '16 16:04 jdm

fair enough, falling back to emilio's idea...

wafflespeanut avatar Apr 25 '16 16:04 wafflespeanut