sergiotarxz

Results 29 comments of sergiotarxz

@Viglino It is not called but the filter affects anyway highly to the performance every time it is rotated the map using: ``` this.map.getView().setRotation((this.compassHeading(alpha, beta, gamma) - this.rotationOffset)) ``` Anyway...

Can I take this issue? And if so should I copy what mojo.js does? Am I supposed to create the missing unit tests? And if I should create the unit...

![Screenshot from 2024-02-14 00-51-58](https://github.com/mojolicious/mojo/assets/25019174/549a64ea-e04b-4dba-b1c9-42d3e5ab8b7e) ![Screenshot from 2024-02-14 00-51-50](https://github.com/mojolicious/mojo/assets/25019174/625fa53b-6678-46ae-ba7a-49e7d0f1ee68) ![Screenshot from 2024-02-14 00-51-32](https://github.com/mojolicious/mojo/assets/25019174/c1ffe787-0fcc-49e8-9aa7-216c6b054dc7) ![Screenshot from 2024-02-14 00-50-54](https://github.com/mojolicious/mojo/assets/25019174/dbda8195-7b0b-4364-978c-bfe27e5350bb) ![Screenshot from 2024-02-14 00-50-44](https://github.com/mojolicious/mojo/assets/25019174/cd4e7142-d19d-4d77-ae38-7dc9f47c825f) ![Screenshot from 2024-02-14 00-50-33](https://github.com/mojolicious/mojo/assets/25019174/62eeacf2-9d8d-40c7-9550-623a20263190) Right new Left Old.

Also this pull requests fixes a bug where `tap for more` was not changing to `tap for less` on click.

There is a screenshot I have not posted ![image](https://github.com/mojolicious/mojo/assets/25019174/484deaad-1d8e-4b3d-9814-f110fc38bf73)

I added use strict to the javascript and discovered a bunch of errors.

I just discovered there was a code path I was not testing, I tested it and fixed the following: * Added popper.js. (Required by tooltip) * Ensured tooltips actually work....

@kraih Would you be in favor of moving the embedded javascript in the template to a file? Maybe in another pr.

The result for `json_message_has` in the negative case is: ``` is_deeply \@args, ['ok', undef, 'has value for JSON Pointer "/test0"']; ``` Which appears sightly inconsistent with other negative cases being...

I think it is not my fault these two test fail: ``` @github-actions linux / perl (5.22) (pull_request) Failing after 2m Required [Details](https://github.com/mojolicious/mojo/actions/runs/7862274388/job/21451556660?pr=2153) @github-actions linux / perl (5.30) (pull_request) Failing...