mojo icon indicating copy to clipboard operation
mojo copied to clipboard

Upgrading to Bootstrap 5 and removing dependency on JQuery.

Open sergiotarxz opened this issue 1 year ago • 6 comments

Summary

Migrating to Boostrap 5 and removing dependency on JQuery.

Motivation

Issue #1975

References

#1975

sergiotarxz avatar Feb 13 '24 23:02 sergiotarxz

Screenshot from 2024-02-14 00-51-58 Screenshot from 2024-02-14 00-51-50 Screenshot from 2024-02-14 00-51-32 Screenshot from 2024-02-14 00-50-54 Screenshot from 2024-02-14 00-50-44 Screenshot from 2024-02-14 00-50-33 Right new Left Old.

sergiotarxz avatar Feb 13 '24 23:02 sergiotarxz

Also this pull requests fixes a bug where tap for more was not changing to tap for less on click.

sergiotarxz avatar Feb 14 '24 10:02 sergiotarxz

There is a screenshot I have not posted image

sergiotarxz avatar Feb 15 '24 00:02 sergiotarxz

I added use strict to the javascript and discovered a bunch of errors.

sergiotarxz avatar Feb 15 '24 22:02 sergiotarxz

I just discovered there was a code path I was not testing, I tested it and fixed the following:

  • Added popper.js. (Required by tooltip)
  • Ensured tooltips actually work.
  • Migrated all data- to data-bs
  • const drawerEl
  • 'use strict'; everywhere
  • In the codepath of 404 debug this should be tested if (handleEl === null) return;

I was not able to take a screenshot to tooltips working though because they depend on the mouse being over them.

sergiotarxz avatar Feb 15 '24 22:02 sergiotarxz

@kraih Would you be in favor of moving the embedded javascript in the template to a file? Maybe in another pr.

sergiotarxz avatar Feb 15 '24 22:02 sergiotarxz

@kraih Would you be in favor of moving the embedded javascript in the template to a file? Maybe in another pr.

Can't say, would depend on how clean the resulting code ends up.

kraih avatar Feb 26 '24 10:02 kraih