mojo icon indicating copy to clipboard operation
mojo copied to clipboard

Update to Bootstrap 5

Open kraih opened this issue 3 years ago • 5 comments

The built-in templates still use Bootstrap 4 and jQuery. In mojo.js we are already using Bootstrap 5 and have removed jQuery. The same should happen for Mojolicious. Slight complication is that the interactive UI elements have no test coverage yet, otherwise this should be very straight forward.

kraih avatar Aug 27 '22 12:08 kraih

Can I help with this issue!?

dvinciguerra avatar Oct 12 '22 18:10 dvinciguerra

Can I help with this issue!?

Of course!

kraih avatar Oct 12 '22 18:10 kraih

Almost done!

image bootstrap current version

image bootstrap 5.2.2

Need some more time to finish the tap for more slider (accordion) and ensure component behaviours are the same on this two versions. =)

dvinciguerra avatar Oct 13 '22 12:10 dvinciguerra

Can I take this issue? And if so should I copy what mojo.js does? Am I supposed to create the missing unit tests? And if I should create the unit test to which extent? Should I do something like this https://github.com/mojolicious/mojo.js/blob/main/test/exception-app.js?

sergiotarxz avatar Feb 12 '24 19:02 sergiotarxz

After two years the issue is definitely up for grabs. No, i don't think you need to add new tests. But you'll have to confirm with screenshots that everything works.

kraih avatar Feb 12 '24 20:02 kraih

Done.

kraih avatar Mar 19 '24 15:03 kraih