Schuyler Eldridge

High level, the "right thing" for deduplication is that you let modules merge, but their annotations become attached to minimal instances. Consider the following circuit: ``` circuit Foo: module Baz:...

@jackkoenig: I think is doing the right thing and the bug is in the transform that is recording the renames. If the transform also changed the instances, then it should...

Reading through this a couple times, I think the question is: **should renames be greedy or not?** I had always thought of renames as not greedy and implemented as a...

I think you're right. (Here's how I got to that point:) Is the set of all full path `InstanceTarget`s pointing at the same module equal to one `ModuleTarget`? I think...

Current output for this looks pretty good! Calling this closed. ```verilog // Generated by CIRCT unknown git version module Foo( input clock, reset, input [1:0] in, output [1:0] outWhen );...

`BoringUtils` was fully migrated to CIRCT and this should now work.

I manually migrated this issue to: https://github.com/chipsalliance/chisel/issues/3053

I'm going to close this given that I think it's fixed. Any issues you're still seeing, feel free to open an issue on upstream Chisel.

@BeenLi: The "could not open pk" seems to indicate that you need a full path to `pk`. There's no discovery of `pk` on your PATH that I'm aware of. Try...

I think you just need to add `$RISCV/bin` to your `$PATH` again. There should be some instructions in the README about this: ```bash export PATH=$RISCV/bin:$PATH ```