Sebb
Sebb
It occurs to me that the code is effectively buffering the output from a BufferedReader (or BufferedInputStream). One would expect these classes to be reasonably fast, however the JVM has...
It looks to me like contentEqualsIgnoreEOLNew2 is using InputReader - I cannot see any buffering?
I see. I would be clearer to use a separate class to implement this. However the method inputOnlyHaveCRLForEOF uses read() on an unbuffered input class. Note that IO has a...
The original comparison methods are easy to follow. It would be good to keep the same clarity by defining new versions of BufferedReader that have good single-threaded performance. Such classes...
AFAICT the new classes UnsyncBufferedReader etc are not actually used (except in test code). I would expect all the contentEquals methods to remain exactly the same except for changes to...
Note that the validator field is package-protected so you could get access from the relevant package (as is done by the test class). Obviously that is not suitable for a...
It would be helpful to add a comment to the copied files pointing to the source of the copy. Now that we are using independent Git repos, it's not possible...
Thanks, but it would be better to link to the actual files please
I agree it would be good to redirect these messages, but notifications@ does not exist (yet)
3.5.3 is OK