Sebb

Results 209 comments of Sebb

Note: if this PR is *not* accepted, then input-helper.ts should probably be fixed to remove the inconsistent default: https://github.com/actions/checkout/blob/8230315d06ad95c617244d2f265d237a1682d445/src/input-helper.ts#L120

I think the example ```John's 1 Doe's [email protected] ```is invalid. Spaces are not allowed in the local-part unless it is quoted. It should be ```"John's 1 Doe's 1-unique-token-identifier"@domain.com```

Sorry, but I am not sufficiently familiar with this part of the code to do a review. Please select someone else.

AFAICT the failures are all in the Ruby setup step. This should have been solved by the fix to install libyaml-dev (not needed for JRuby, hence they succeeded). Just trigger...

It would be helpful if you could trigger a CI rebuild by making a trivial change. Rebasing would probably also work, though I'm not sure it's necessary here.

I think there needs to be a test to show that the original boundary can still be generated and used. Also: if certain characters need to be quoted, who is...

Redundant as 2.7 no longer in development

Fixed in 1bc542778bb3792e90996ef18c3b938791a92c90

A separate table would be fine. Once the class names are documented, users can at least search the source for the class name. Better would be links to documentation such...

Yes, I should be able to do some of the work