commons-beanutils icon indicating copy to clipboard operation
commons-beanutils copied to clipboard

Remove Commons Collections Test Framework

Open melloware opened this issue 5 years ago • 5 comments
trafficstars

Commons Collection Test Framework is... a) no longer supported b) has not been built since 2013 c) does NOT even have a POM in Maven Central its just a JAR.

So BeanUtils2 should not be depending on it. This PR removes that dependency and brings in the code necessary for the unit tests.

melloware avatar Sep 20 '20 16:09 melloware

It would be helpful to add a comment to the copied files pointing to the source of the copy. Now that we are using independent Git repos, it's not possible to track copies across Commons components.

sebbASF avatar Oct 09 '20 12:10 sebbASF

Added to each class header:

 * <p>
 * Copied from Commons Collection 4.
 * @see <a href="https://github.com/apache/commons-collections">Commons Collections 4</a>

melloware avatar Oct 09 '20 13:10 melloware

Thanks, but it would be better to link to the actual files please

sebbASF avatar Oct 09 '20 14:10 sebbASF

Good idea all links updated to point to their original file in GitHub.

melloware avatar Oct 09 '20 14:10 melloware

I'll try and take a look this week...

garydgregory avatar Aug 03 '21 17:08 garydgregory