Sebb

Note: same typo appears in 2-7-stable etc

It's not at all obvious. Although technically I suppose reporting a bug or requesting an enhancement is contributing, that's not how I think of it. I suspect others will agree....

Anyone with write access to [1] -- this includes all PMC members -- can generate and upload the hashes. [1] https://dist.apache.org/repos/dist/release/royale/compiler-build-tools/1.2.0/binaries/

If I understand the benchmark correctly, the New method is approx 3% slower for Test1 and about 2% faster for Test2. Does not seem like a huge gain.

The JMH results are very long and obscure the thread of the PR. Is it possible to post just the summary inline, with a link to the full results in...

Thanks - much easier to see what has been changed now. i.e. cache the string length, and don't use substring unless it is needed. I don't think the RandomStrings test...

Sorry, I see now that the strings do have a mix of CR and LF endings (or neither). However, the strings are all of length 2. The strings are not...

I think the current huge list of input strings is more about testing functionality rather than performance. The method only cares about 3 characters: CR, LF or something else (unless...

You are correct - I was forgetting that the characters could be missing. As to testing the length, yes I think we do need to test for various lengths. Longer...

The code needs comments. It's not clear what the variables are doing, nor what the algorithm is. In the case of contentEquals(InputStream...) and contentEquals(Reader ...) it would be enough to...