Sebastien Rosset

@bmatcuk would you be able to review?

If `doublestar.FilepathGlob()` does not return `filepath.ErrBadPattern`, then it's not really a drop-in replacement as documented here: https://github.com/bmatcuk/doublestar/blob/master/utils.go#L68-L70. In that case I think we should clarify the return errors are not...

> The current message states the 'plugin name', the 'actual file' causing the issue and lists 'the fragments' that are causing the issue. I'm not sure the proposed rewrite is...

Doesn't the search path depend on the fragment loader, which uses [DOC_FRAGMENT_PLUGIN_PATH](https://docs.ansible.com/ansible/latest/reference_appendices/config.html#doc-fragment-plugin-path)?

> I'm not sure how to proceed from here, the message already contains the collection path (module is inside the collection) and the search path for the doc_fragments is basically...

> I did not think it needed to be documented, collection fragments are looked for .. in the collection, it makes no sense to use a search path when you...

I am trying to understand how gogrep matches AST nodes when invoked as `gogrep -x '$x{$*_}'`. It's not immediately obvious how it works. That command seems to match any statement...

I'm just starting to read the code. Is aggressive supposed to be an option like like regex greedy vs reluctant vs possessive? BTW, I found it is very helpful to...

> True that ... Thx. for contributing!. @skalle Is anything preventing the merge?

One use case would be to gracefully notify clients that connections are going to be closed. Golang net.http.Server supports Shutdown() and Close() to terminate connections.