Sebastien Rosset
Sebastien Rosset
Before I start, I'd like to see that at least one other PR is accepted and merged. I would like to get some confidence that submissions are actually accepted (obviously...
Gently trying to get this pull request reviewed. Thank you.
Thanks!! The alternative looks good to me. Feel free to decline this PR.
@quasilyte , am I doing something wrong? Is it possible to test go-critic when it's a fork?
I have raised a pull request to describe the settings in more detail: https://github.com/golangci/golangci-lint/pull/1562
What do you think about supporting `**` glob expansion using one of the libraries listed here: https://www.client9.com/golang-globs-and-the-double-star-glob-operator/? 1. [mattn/go-zglob](https://github.com/mattn/go-zglob) looks very optimized for filewalking 1. [bmatcuk/doublestar](https://github.com/bmatcuk/doublestar) appears to be the...
What do you think about adding support for double star operator using one of the libraries listed here: https://www.client9.com/golang-globs-and-the-double-star-glob-operator/
For the `gocritic` example, there are three possible levels: `gocritic:ruleguard:ruleguard-rule-name`. Ruleguard is a powerful checker under `gocritic`, and within ruleguard it's possible to have hundreds of checks.
Thanks. If that's the case, then yes the [specification for attributes naming](https://opentelemetry.io/docs/reference/specification/common/attribute-naming/) should be updated. This would apply to #3131 as well. Given that the spec explicitly states attribute names...
Presumably the spec would also have to state something about naming conventions for attributes defined in the spec itself versus attributes defined by other organizations. Someone could create metric-level attributes...