Fixed dark mode bugs in the availability section

[MaheshB77]

What does this PR do?

• Fixed dark mode bugs in the availability section

Fixes #8628

1. "Set as default" on hover was getting a white background, FIXED

2. Delete icon on hover was not showing the proper tooltip and background color, FIXED

3. Delete icon on hover should be red, FIXED

Environment: Production

Type of change

• Bug fix (non-breaking change which fixes an issue)

How should this be tested?

• Can be tested by visiting /availability section

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 14, 2023 4:53pm
ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 14, 2023 4:53pm

[vercel[bot]]

@MaheshB77 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions[bot]]

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

[keithwillcode]

@MaheshB77 I'm still seeing this message on the preview deployment.

[MaheshB77]

Looks like the message to delete a 2nd working hours is saying "You are required to have at least one schedule."

Yes @keithwillcode, I did remove that message in my 1st commit but reverted back as per @Udit-takkar 's suggestion to keep it as it is

[Udit-takkar]

@MaheshB77 actually we have to show this tooltip to tell the user why delete icon is disabled when you try to delete one and only availability. just add a condition if schedule?.isLastSchedule then show requires_at_least_one_schedule else delete tooltip message

[MaheshB77]

That makes sense @Udit-takkar , I will update the PR accordingly, Thanks 🥂.

[MaheshB77]

@MaheshB77 actually we have to show this tooltip to tell the user why delete icon is disabled when you try to delete one and only availability. just add a condition if schedule?.isLastSchedule then show requires_at_least_one_schedule else delete tooltip message

@Udit-takkar @keithwillcode Can you guys check now, I have updated the tooltip based on schedule?.isLastSchedule flag

[Udit-takkar]

Just need to confirm one thing from @sean-brydon

2. This is current ui when you hover over disabled delete button but i think 1 is better. was this intentional ?

[Udit-takkar]

I have pushed this now

[zeeshanbhati]

@MaheshB77, @Udit-takkar Just a suggestion that don't you think the hover effect on the set as default button should be bg-subtle, I checked the toggle button in event-type/[id] it has a hover effect of bg-subtle and cursor pointer should stay there, that toggle should look like that it works on the title click as well

SS From event-type/[id]

[sean-brydon]

@MaheshB77, @Udit-takkar Just a suggestion that don't you think the hover effect on the set as default button should be bg-subtle, I checked the toggle button in event-type/[id] it has a hover effect of bg-subtle and cursor pointer should stay there, that toggle should look like that it works on the title click as well

SS From event-type/[id]

Ill fix this in a follow up PR thank you :)

[zeeshanbhati]

@MaheshB77, @Udit-takkar Just a suggestion that don't you think the hover effect on the set as default button should be bg-subtle, I checked the toggle button in event-type/[id] it has a hover effect of bg-subtle and cursor pointer should stay there, that toggle should look like that it works on the title click as well SS From event-type/[id]

Ill fix this in a follow up PR thank you :)

@sean-brydon #8680 already does that, you can cherry-pick that commit into this PR :)

[sean-brydon]

@MaheshB77, @Udit-takkar Just a suggestion that don't you think the hover effect on the set as default button should be bg-subtle, I checked the toggle button in event-type/[id] it has a hover effect of bg-subtle and cursor pointer should stay there, that toggle should look like that it works on the title click as well SS From event-type/[id]

Ill fix this in a follow up PR thank you :)

@sean-brydon #8680 already does that, you can cherry-pick that commit into this PR :)

Thank you! Me and @Jaibles are reworking the switch component so will likely keep this in a separate PR. Thanks again!

[Udit-takkar]

@MaheshB77 can you fix merge conflicts ?

[MaheshB77]

@MaheshB77 can you fix merge conflicts ?

@Udit-takkar Done, can you please merge this PR now 🙂