Shane da Silva

Results 170 comments of Shane da Silva

Sorry for the delay. Failures seem unrelated to your changes, going to go ahead and merge.

Attempted to address in #216, but this would require a maintainer to approve and then initiate a version bump. @vweevers since you added the `pull request welcome` label, would you...

Thanks for triaging this as ready for review, @vweevers. As it's been a month, wanted to check in on whether there's anything I can do to help get this merged...

No strong opinion from me. Easier to provide input on a PR 🙂 Could also just disable that particular cop for HAML files, if a bandaid fix is desired.

Hey @CoderMiguel, thanks for your effort on this. As mentioned in [this comment](https://github.com/sds/mock_redis/issues/281#issuecomment-1884032329), very supportive of dropping support for `redis-rb` < 5 if it makes it easier for us to...

Thanks for the feedback! Would you want a separate test file for `isPlainObject`, or tests added to the existing [camel case plugin tests](https://github.com/kysely-org/kysely/blob/3d5e0e59d5536e2dbfee8e39ebecd0b5d981536e/test/node/src/camel-case.test.ts)? In the meantime, I pushed an updated...

Tests were converted to GitHub Actions in #175. Can we remove the required Appveyor check when you get a chance, @enkessler?

@enkessler I'm fine with just removing the AppVeyor webhooks for now if that's possible. Would be nice to keep the project around so links to builds still work for now....

`childprocess` will no longer use/require `ffi` as of version 5.x, which was just released.

Thank you! Superseded by #175.